Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flashing on WSL1 (VSC-580) #331

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

risinek
Copy link
Contributor

@risinek risinek commented Feb 25, 2021

This was originally caused by #224. Then it was partially fixed by #298 but flash/flashTask.ts was missed.

In this PR I just copypasted fix by @brianignacio5 to a missing spot.

Fix #295

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Thanks for your PR !

Will just remove the console.log line.

@github-actions github-actions bot changed the title Fix flashing on WSL1 Fix flashing on WSL1 (VSC-580) Feb 26, 2021
@brianignacio5 brianignacio5 merged commit 823c14a into espressif:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Flashing through WSL1 environment not working since v0.6.0 (VSC-549)
2 participants