Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative links in tasks output, truncated export cmd in terminal #337

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Mar 1, 2021

Fix #333

Fix #266

Fix #329

Use vscode ShellExecution to fix relative paths link in build/flash task outputs. PTAL @boarchuz

Remove export cmd and use strict env for Monitor terminal and ESP-IDF Terminal . PTAL @resetnow

Fix closing monitor issues when flash is trigger. PTAL @seulater

@vlad-ivanov-name
Copy link

vlad-ivanov-name commented Mar 1, 2021

@brianignacio5 thank you for the update, I tested this PR and I'm observing the following:

  1. after a fresh start, monitor command works 🎉
  2. after a fresh start, build-flash-monitor sequence works
  3. unfortunately, if the monitor is running and I'm trying to flash, there will be an error:

image

I think the reason is that the serial resource is not released quickly enough - perhaps the terminal is closed or the process is killed asynchronously?

If I retry immediately after this error, it will flash successfully.

@brianignacio5
Copy link
Collaborator Author

brianignacio5 commented Mar 2, 2021

I think is about giving enough time for monitor to be disposed. Will check if we have access to terminal disposed event and exit status, timeout is a tricky thing, otherwise just add a timeout configuration setting for this.

Please try again @resetnow, after last commit (2677315) I can't reproduce anymore.

@vlad-ivanov-name
Copy link

This works better - I haven't been able to find any problems

@brianignacio5 brianignacio5 merged commit 2df42de into master Mar 3, 2021
@brianignacio5 brianignacio5 deleted the bugfix/tasks-relative-file-links branch May 8, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
2 participants