Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create container dir only on esp idf download #591

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

brianignacio5
Copy link
Collaborator

Fix #589

Setup was creating ~/esp when it didn't need to (find esp-idf in your system), this PR makes sure it is created on the right use case.

@brianignacio5 brianignacio5 self-assigned this Dec 14, 2021
@brianignacio5 brianignacio5 merged commit 3c85c43 into master Dec 15, 2021
@brianignacio5 brianignacio5 deleted the bugfix/unused-container-creation branch December 15, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Advanced setup creates unnecessary directory ~/esp (VSC-800)
1 participant