Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch cmakelists txt error sdkconfig file access #909

Merged
merged 3 commits into from
Apr 4, 2023
Merged

catch cmakelists txt error sdkconfig file access #909

merged 3 commits into from
Apr 4, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Mar 16, 2023 •
edited
Loading

Description

Catch CMakeLists.txt file access error reading IDF Target on extension activation.

Fixes #897
Fix #905
Fix #907
Fix #911

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS Ventura

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Mar 16, 2023
@brianignacio5 brianignacio5 added this to the 1.6.1 milestone Mar 16, 2023
@brianignacio5 brianignacio5 self-assigned this Mar 16, 2023
@github-actions
Copy link

github-actions bot commented Mar 16, 2023 •
edited
Loading

Download the artifacts for this pull request:

radurentea
radurentea approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

Hi @brianignacio5 !

Tested #907 on Linux Ubuntu
VS Code: 1.76.2
LGTM 👍

Tested #911 on Windows 10
VS Code: 1.76.2
Tested basic ESP-IDF extensions (build project / open CMakeList Editor / Partition table editor)
LGTM 👍

Tested #905 on Mac
VS Code: 1.76.2
IN PROGRESS

@brianignacio5 brianignacio5 merged commit 368827b into master Apr 4, 2023
@brianignacio5 brianignacio5 deleted the bugfix/cmakelists-txt branch April 4, 2023 06:35
@brianignacio5 brianignacio5 mentioned this pull request Apr 6, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radurentea radurentea radurentea approved these changes

Assignees

@brianignacio5 brianignacio5

Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
Milestone
1.6.1
3 participants
@brianignacio5 @AndriiFilippov @radurentea