add custom terminal executable settings #973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
idf.customTerminalExecutable
andidf.customTerminalExecutableArgs
to customize the shell executable and shell arguments used in the extension tasks. By default it will use the vscode configured terminal.Added them also to
ESP-IDF: Doctor command
output.Shell arguments are also required as specified in VSCODE API for
ShellExecutionOptions
:Fixes #935
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
idf.customTerminalExecutable
not defined.idf.customTerminalExecutable
in settings.json to any custom terminal like/bin/bash
and requiredidf.customTerminalExecutableArgs
like["-c" ]
for Bash or corresponding for commands.ESP-IDF: Build your project
commands. Check in the output that is using the custom terminal executable.How has this been tested?
Manual testing
Test Configuration:
Checklist