Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a project from external components #994

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

radurentea
Copy link
Collaborator

@radurentea radurentea commented Jun 15, 2023

Description

Users are now able to create projects from the examples that can be found in Component Registry.

  • Link that opens "Component Registry" was added in the webview of "ESP-IDF: Show Example Projects"
  • Button for creating projects from examples was added in the "Component Registry" webview

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Steps to test this pull request

  1. Open Command Palette (CTRL + SHIFT + P) in VSCode and type ESP-IDF: Show Example Projects
  2. Press the top left link "IDF Component Registry"
  3. Search for "cmp" in the search box.
  4. Click the "Create project from example"
  5. Select Folder where you want the project to be created

Expected behaviour:

New window should open with the newly created project.

How has this been tested?

Tested by following the steps above on Mac.

Test Configuration:

  • ESP-IDF Version: 5.2.0
  • OS (Windows,Linux and macOS): Mac and Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this Jun 15, 2023
@radurentea radurentea added the ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot label Jun 15, 2023
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Download the artifacts for this pull request:

@radurentea radurentea removed the ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot label Jul 25, 2023
@radurentea radurentea marked this pull request as ready for review July 25, 2023 14:24
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

@radurentea hi !

Tested under:
OS - Windows 10
VS Code: 1.81.1
ESP-IDF: v5.1
CMakeOutput.log

Can't build the "Component Registry" cmp project.
LOGS:

-- Found Git: C:/Users/AndriiFilippov/.espressif/tools/idf-git/2.39.2/cmd/git.exe (found version "2.39.2.windows.1")
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/Users/AndriiFilippov/.espressif/tools/xtensa-esp32-elf/esp-12.2.0_20230208/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc.exe
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Users/AndriiFilippov/.espressif/tools/xtensa-esp32-elf/esp-12.2.0_20230208/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Users/AndriiFilippov/.espressif/tools/xtensa-esp32-elf/esp-12.2.0_20230208/xtensa-esp32-elf/bin/xtensa-esp32-elf-g++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Project is not inside a git repository, or git repository has no commits; will not use 'git describe' to determine PROJECT_VER.
-- Building ESP-IDF components for target esp32
Dependencies lock doesn't exist, solving dependencies.
CMake Error at C:/Users/AndriiFilippov/e/esp-idf-v5.1/tools/cmake/build.cmake:540 (message):  ERROR: Solver failed processing dependency "example/cmp" from the manifest
  file
  "C:/Users/AndriiFilippov/Desktop/Radu/hello_world/cmp_ex/main\idf_component.yml".


  The override_path you're using is pointing to directory
  "C:\Users\AndriiFilippov\Desktop\Radu" that is not a component.

Call Stack (most recent call first):
  C:/Users/AndriiFilippov/e/esp-idf-v5.1/tools/cmake/project.cmake:464 (idf_build_process)  
  CMakeLists.txt:8 (project)


-- Configuring incomplete, errors occurred!
See also "C:/Users/AndriiFilippov/Desktop/Radu/hello_world/cmp_ex/build/CMakeFiles/CMakeOutput.log".

 *  The terminal process "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command cmake -G Ninja -DPYTHON_DEPS_CHECKED=1 -DESP_PLATFORM=1 -B c:\Users\AndriiFilippov\Desktop\Radu\hello_world\cmp_ex\build -S c:\Users\AndriiFilippov\Desktop\Radu\hello_world\cmp_ex" terminated with exit code: 1. 

@AndriiFilippov
Copy link
Collaborator

@radurentea

secondary:
some links are inactive on ESP Registry page.

image

@brianignacio5 brianignacio5 added this to the v1.7.0 milestone Aug 24, 2023
@radurentea
Copy link
Collaborator Author

Hi @AndriiFilippov ,

Please re-test it with the last fix for the building issue.

In regards to the links, it's a separate issue and we should create a different task for it, most of it it has to do with changes on the Component Manager side.

@AndriiFilippov
Copy link
Collaborator

@radurentea hi !

Tested under:
OS: Windows 10 / Linux Ubuntu / MacOS
VS Code: 1.81.1
ESP-IDF: v5.1 / v5.0

Able to build the "Component Registry" cmp project.
LGTM 👍

@radurentea radurentea merged commit 0de6afe into master Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants