-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the walberla bridge to a self-contained git repo #4723
Comments
Make the walberla_bridge (located in src/walberla_bridge) an independent library, i.e.,
The goal is that the library can be used by other codes than Espresso, e.g., our parterns in MultiXScale. |
Requirements:
|
The first step is to
Once the Walberla bridge can be built in its own repo independently of ESPRso, we'll sort out using that new repo from Espresso. |
A proof-of-concept can be found in jonscheunemann/walberla_bridge. Thanks @jonscheunemann and Marc Sauter! Once we're done with the major LB/EK rewrite, we'll be able to use that work to create the bridge as part of the ESPResSo organization. I'll take care of resolving any remaining CMake subtleties with the |
Description of changes: - API changes: - the `espressomd.System` class now has a new member `lb` - the `espressomd.System` class member `ekreactions` is now the `reaction` attribute of `system.ekcontainer` - the `espressomd.System` class no longer has an `actors` member - further API changes will take place in an upcoming PR - remove Boost dependency from LB/EK sources - follow-up to [**Remove remaining boost components** walberla/walberla#605](https://i10git.cs.fau.de/walberla/walberla/-/merge_requests/605) - partial fix for #4723 (comment) - unit tests from the walberla bridge still depend on `Boost::unit_test_framework` - fix regressions in EK - EK now throws an error when the box_l or node_grid changes, when the MD time step and EK tau disagree, when the box size is not an integer multiple of agrid - rewrite the LB and EK code in the core from scratch to enforce SOLID principles - folder `src/grid_based_algorithms` was split into `src/core/lb` and `src/core/ek` - LB and EK global variables (`lattice_switch`, `ek_container`, `ek_reactions`, `lb_walberla_instance`, `lb_walberla_params_instance`) were removed; these objects are now members of the `System` class (partial fix for #2628)
No description provided.
The text was updated successfully, but these errors were encountered: