Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SD #1094

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Remove SD #1094

merged 1 commit into from
Jul 13, 2017

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented Apr 19, 2017 •
edited
Loading

Fixes #233, #624, and #1091

@hmenke hmenke added the Core label Apr 19, 2017
@hmenke hmenke requested a review from fweik April 19, 2017 22:25
@RudolfWeeber
Copy link
Contributor

RudolfWeeber commented Apr 20, 2017 via email

fweik
fweik suggested changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@fweik fweik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires offline discussion

@hmenke
Copy link
Member Author

hmenke commented May 18, 2017

I heard that in the meeting a few weeks ago SD was scheduled for removal. What is blocking the merge of this one?

@fweik
Copy link
Contributor

fweik commented Jun 20, 2017

The duplicated main loop that comes with SD is very hard to maintain and has already diverged quiet a bit from the other stuff. If @dschwoerer or somebody else is willing to integrate the method with the normal main loop I will remove it.

@dschwoerer
Copy link
Contributor

I am slightly sad to see SD go. I am not using espresso any more, and if there is nobody else who uses it ...

If there would be use for the SD/BD integrators, I could be bothered, but I don't think that this is currently the case ...

@hmenke
Copy link
Member Author

hmenke commented Jul 6, 2017

Can this be merged?

@fweik
Copy link
Contributor

fweik commented Jul 13, 2017

We would also be more happy if we had SD, but we can not fix it at the moment. The code is not lost, and if we find a student in the future we will pick this up again.

@fweik fweik merged commit 1805f54 into espressomd:python Jul 13, 2017
@hmenke hmenke deleted the remove_sd branch July 13, 2017 08:51
@bogdan-tanygin bogdan-tanygin mentioned this pull request Aug 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fweik fweik fweik approved these changes

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hmenke @RudolfWeeber @fweik @dschwoerer