Lb cleanup #1900
Merged
Lb cleanup #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #1900 +/- ##
======================================
- Coverage 61% 61% -1%
======================================
Files 438 438
Lines 29212 29209 -3
======================================
- Hits 17877 17874 -3
Misses 11335 11335
Continue to review full report at Codecov.
|
KaiSzuttor
approved these changes
Mar 13, 2018
|
why does removing code decrease coverage? |
|
Because the statistical tests are non-deterministic and the fluctuation is much larger than the impact of your removal. |
ashreyaj
pushed a commit
to ashreyaj/espresso
that referenced
this pull request
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unused code from LB. There is still more (D3Q19, PULL/PUSH).