Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Work around another boost.mpi bug #2421

Closed
wants to merge 5 commits into from
Closed

core: Work around another boost.mpi bug #2421

wants to merge 5 commits into from

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Dec 17, 2018

Older versions of boost.mpi had a broken implementation of communicator::isend for non-mpi data types. This works around that.

@fweik fweik requested a review from mkuron December 17, 2018 17:57
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #2421 into python will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2421    +/-   ##
=======================================
+ Coverage      72%     72%   +<1%     
=======================================
  Files         397     397            
  Lines       18666   18678    +12     
=======================================
+ Hits        13496   13508    +12     
  Misses       5170    5170
Impacted Files Coverage Δ
src/core/utils/mpi/sendrecv.hpp 100% <100%> (ø) ⬆️
src/core/unit_tests/sendrecv_test.cpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d608a14...a3ddcb5. Read the comment docs.

@mkuron
Copy link
Member

mkuron commented Dec 19, 2018

I think we might be able to put a fixed version of mpi::communicator::isend into a cpp file, build that to a shared library with -Wl,-z -Wl,interpose and link it into Espresso. Of course, we'd only do that on Linux platforms and only if we are below Boost 1.68.0.

@mkuron
Copy link
Member

mkuron commented Dec 19, 2018

For reference, this is the patch: boostorg/mpi@e3b0d08. It was first included in Boost 1.67.0.

@fweik fweik deleted the isend branch August 27, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants