Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed FFT code duplication #2455

Merged
merged 10 commits into from
Jan 22, 2019
Merged

Removed FFT code duplication #2455

merged 10 commits into from
Jan 22, 2019

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Jan 21, 2019

Removed 2nd identical implementation of 3d FFT for dipolar p3m.

@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #2455 into python will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2455    +/-   ##
=======================================
- Coverage      70%     70%    -1%     
=======================================
  Files         488     487     -1     
  Lines       30863   30639   -224     
=======================================
- Hits        21747   21563   -184     
+ Misses       9116    9076    -40
Impacted Files Coverage Δ
src/core/electrostatics_magnetostatics/p3m.hpp 100% <ø> (ø) ⬆️
...core/electrostatics_magnetostatics/p3m-dipolar.hpp 100% <ø> (ø) ⬆️
src/core/electrostatics_magnetostatics/icc.cpp 64% <ø> (ø) ⬆️
src/core/electrostatics_magnetostatics/p3m.cpp 83% <100%> (ø) ⬆️
...core/electrostatics_magnetostatics/p3m-dipolar.cpp 79% <100%> (ø) ⬆️
src/core/electrostatics_magnetostatics/fft.cpp 88% <100%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f33a4...8ef1aab. Read the comment docs.

@fweik fweik merged commit 7ecb048 into espressomd:python Jan 22, 2019
@fweik fweik deleted the fft branch January 22, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants