Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add soversion to libH5mdCore #3226

Closed
wants to merge 1 commit into from
Closed

Conversation

junghans
Copy link
Member

@junghans junghans commented Oct 1, 2019

Just #2946 again, not why it didn't make it in v4.1

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #3226 into 4.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             4.1   #3226   +/-   ##
=====================================
  Coverage     85%     85%           
=====================================
  Files        530     530           
  Lines      26025   26025           
=====================================
  Hits       22157   22157           
  Misses      3868    3868

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffa392...94f73bf. Read the comment docs.

Copy link
Member

@mkuron mkuron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Seems like we forgot to cherry-pick it into the master branch. We'll definitely need to do that now.

@KaiSzuttor
Copy link
Member

@junghans could you please explain why this is needed?

@mkuron
Copy link
Member

mkuron commented Oct 2, 2019

Generating a Fedora RPM throws a warning if a library isn't versioned, if I remember correctly. An unversioned library is named libSomething.so, while a versioned library is named libSomething.so.4 with a symlink libSomething.so pointing to it.

pdbreader.so, mpiio.so and pdbparser.so are also missing versions.

@junghans
Copy link
Member Author

junghans commented Oct 2, 2019

In general shared libraries should be versioned, but now as everything gets installed in the pythondir we could drop the soversion completely.

And there is another bug as pdbreader and mpiio don't get installed at all.

@junghans
Copy link
Member Author

junghans commented Oct 2, 2019

See #3228 for replacement.

@junghans junghans closed this Oct 2, 2019
@junghans junghans deleted the 4.1 branch October 2, 2019 15:09
@junghans junghans mentioned this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants