-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve documentation of the Widom insertion method #3254
improve documentation of the Widom insertion method #3254
Conversation
Codecov Report
@@ Coverage Diff @@
## python #3254 +/- ##
======================================
- Coverage 86% 86% -1%
======================================
Files 538 538
Lines 25346 25350 +4
======================================
- Hits 21831 21830 -1
- Misses 3515 3520 +5
Continue to review full report at Codecov.
|
@kosovan, would you be willing to review this? |
@RudolfWeeber I should be able to do it on Tuesday or Wednesday. I am not sure if that is not too late but I have some teaching duties that cannot be postponed. |
… set. For generality I also added the ability to remove reactions which were added to a reaction system
@helvrud I implemented the ability to change the reaction constant or delete reactions you already added: deletion of a given reaction:
change of the reaction constant (back and forward reaction simultaneously):
|
@jonaslandsgesell this pr adds functionallity in addition to docs. Please edit the description to explain this PRś intention |
bors r+ |
👎 Rejected by code reviews |
@kosovan could you mark your comments as resolved? Otherwise the merge cannot proceed and people do not find documentation about the method. If there are remaining problems please open a new issue for them. |
@jonaslandsgesell that's an issue of bors actually |
bors r+ |
👎 Rejected by code reviews |
@KaiSzuttor it's actually a feature, |
Should this PR be milestoned as 4.2 or 4.1.2? |
Should this PR be milestoned as 4.2 or 4.1.2?
Ideally, this should have been two PRs. Since the potential of side effects is small in this case, I’d be OK with 4.1.2
|
Hey guys, I apologize for the late response. I was not aware that this was waiting for me to mark my requests as resolved. Sorry if I delayed the merge unnecessarily. |
@kosovan as I said, that's not your fault. It's a bug of the mergebot. |
This PR adds documentation for the Widom insertion method.
In addition it adds the feature to change reaction constants and delete reactions. This is functionality which Oleg (@helvrud) suggested and which gives some more flexibility to the user.