Bit Mask utility function #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3265 +/- ##
=======================================
+ Coverage 86% 86% +<1%
=======================================
Files 530 533 +3
Lines 25647 25643 -4
=======================================
+ Hits 22061 22062 +1
+ Misses 3586 3581 -5
Continue to review full report at Codecov.
|
src/utils/include/utils/mask.hpp
Outdated
| template <class T, class Integral> | ||
| auto mask(Integral mask, T t) | ||
| -> std::enable_if_t<std::is_unsigned<Integral>::value && | ||
| (8 * sizeof(Integral) >= tuple_size<T>::value), |
There was a problem hiding this comment.
Where does the 8 come from?
There was a problem hiding this comment.
I gave it a name, you were the second person to ask this ^^
RudolfWeeber
approved these changes
Oct 20, 2019
|
bors r=RudolfWeeber |
bors bot
added a commit
that referenced
this pull request
Oct 20, 2019
3265: Bit Mask utility function r=RudolfWeeber a=fweik
Description of changes:
- tuple interface for Utils::{Array, Vector}
- Extract bit masking utility function to utils
- Some small code modernization
Co-authored-by: Florian Weik <[email protected]>
Build failed |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 20, 2019
3265: Bit Mask utility function r=RudolfWeeber a=fweik
Description of changes:
- tuple interface for Utils::{Array, Vector}
- Extract bit masking utility function to utils
- Some small code modernization
Co-authored-by: Florian Weik <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: