Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost communicator cleanup #3272

Merged
merged 9 commits into from
Oct 23, 2019
Merged

Ghost communicator cleanup #3272

merged 9 commits into from
Oct 23, 2019

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Oct 22, 2019

Description of changes:

  • Removed data_parts stored in GhostCommunicator
  • Removed redundant GhostCommunicators

@fweik fweik self-assigned this Oct 22, 2019
@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #3272 into python will decrease coverage by <1%.
The diff coverage is 98%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3272   +/-   ##
======================================
- Coverage      86%     86%   -1%     
======================================
  Files         533     533           
  Lines       25631   25583   -48     
======================================
- Hits        22051   22007   -44     
+ Misses       3580    3576    -4
Impacted Files Coverage Δ
src/core/ghosts.hpp 100% <ø> (ø) ⬆️
src/core/cells.hpp 100% <ø> (ø) ⬆️
src/core/nsquare.cpp 100% <100%> (ø) ⬆️
src/core/virtual_sites/VirtualSitesRelative.cpp 86% <100%> (ø) ⬆️
...e/virtual_sites/VirtualSitesInertialessTracers.cpp 100% <100%> (ø) ⬆️
src/core/forces.cpp 100% <100%> (ø) ⬆️
src/core/virtual_sites/lb_inertialess_tracers.cpp 96% <100%> (ø) ⬆️
src/core/rattle.cpp 90% <100%> (ø) ⬆️
src/core/cells.cpp 89% <100%> (ø) ⬆️
src/core/domain_decomposition.cpp 94% <100%> (-1%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348a04e...44c7e62. Read the comment docs.

@fweik
Copy link
Contributor Author

fweik commented Oct 23, 2019

bors r=RudolfWeeber

bors bot added a commit that referenced this pull request Oct 23, 2019
3272: Ghost communicator cleanup r=RudolfWeeber a=fweik

Description of changes:
 - Removed data_parts stored in GhostCommunicator
 - Removed redundant GhostCommunicators



Co-authored-by: Florian Weik <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 23, 2019

Build succeeded

@bors bors bot merged commit 44c7e62 into espressomd:python Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants