Re-enable pylint in CI #3293
Merged
Re-enable pylint in CI #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f2ea574.
Script `maintainer/gh_post_pylint.py` is derived from script `maintainer/gh_post_docs_warnings.py`.
|
espresso-ci correctly posted a message with a excerpt of the pylint report |
These version numbers are the default in Ubuntu 19.10.
Make sure espresso-ci deletes the correct message using well-defined tokens that are guanranteed to be in the posted message. Don't silently ignore Python exceptions.
Codecov Report
@@ Coverage Diff @@
## python #3293 +/- ##
======================================
- Coverage 86% 86% -1%
======================================
Files 536 534 -2
Lines 25574 25510 -64
======================================
- Hits 22004 21939 -65
- Misses 3570 3571 +1
Continue to review full report at Codecov.
|
christophlohrmann
approved these changes
Nov 6, 2019
fweik
approved these changes
Nov 11, 2019
|
bors r=fweik |
bors bot
added a commit
that referenced
this pull request
Nov 11, 2019
3279: Replaced some manual memory allocations r=jngrad a=reinaual Partially adresses #2900 3293: Re-enable pylint in CI r=fweik a=jngrad Fixes #3194 Rules: `W0102,W0401,W0611,W0612,W0613,W0614,W1505,R0401,R1707,C0202,E0602` * `W0102`: dangerous-default-value * `W0401`: wildcard-import * `W0611`: unused-import * `W0612`: unused-variable * `W0613`: unused-argument * `W0614`: unused-wildcard-import * `W1505`: deprecated-method * `R0401`: cyclic-import * `R1707`: trailing-comma-tuple * `C0202`: bad-classmethod-argument * `E0602`: undefined-variable Co-authored-by: Alexander Reinauer <[email protected]> Co-authored-by: Jean-Noël Grad <[email protected]>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Nov 11, 2019
3293: Re-enable pylint in CI r=fweik a=jngrad Fixes #3194 Rules: `W0102,W0401,W0611,W0612,W0613,W0614,W1505,R0401,R1707,C0202,E0602` * `W0102`: dangerous-default-value * `W0401`: wildcard-import * `W0611`: unused-import * `W0612`: unused-variable * `W0613`: unused-argument * `W0614`: unused-wildcard-import * `W1505`: deprecated-method * `R0401`: cyclic-import * `R1707`: trailing-comma-tuple * `C0202`: bad-classmethod-argument * `E0602`: undefined-variable Co-authored-by: Jean-Noël Grad <[email protected]>
|
bors r- |
Canceled |
|
bors r=fweik |
bors bot
added a commit
that referenced
this pull request
Nov 11, 2019
3279: Replaced some manual memory allocations r=jngrad a=reinaual Partially adresses #2900 3293: Re-enable pylint in CI r=fweik a=jngrad Fixes #3194 Rules: `W0102,W0401,W0611,W0612,W0613,W0614,W1505,R0401,R1707,C0202,E0602` * `W0102`: dangerous-default-value * `W0401`: wildcard-import * `W0611`: unused-import * `W0612`: unused-variable * `W0613`: unused-argument * `W0614`: unused-wildcard-import * `W1505`: deprecated-method * `R0401`: cyclic-import * `R1707`: trailing-comma-tuple * `C0202`: bad-classmethod-argument * `E0602`: undefined-variable Co-authored-by: Alexander Reinauer <[email protected]> Co-authored-by: Jean-Noël Grad <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3194
Rules:
W0102,W0401,W0611,W0612,W0613,W0614,W1505,R0401,R1707,C0202,E0602W0102: dangerous-default-valueW0401: wildcard-importW0611: unused-importW0612: unused-variableW0613: unused-argumentW0614: unused-wildcard-importW1505: deprecated-methodR0401: cyclic-importR1707: trailing-comma-tupleC0202: bad-classmethod-argumentE0602: undefined-variable