Modernize core #3314
Merged
Modernize core #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use bool type for true/false flags, update docs of bitfield flags.
Narrow scope of local variables, use auto const and static_cast.
Remove commented out debug printf statements, format comments, update doxygen comments, delete obsolete doxygen comments.
Codecov Report
@@ Coverage Diff @@
## python #3314 +/- ##
=======================================
+ Coverage 86% 86% +<1%
=======================================
Files 536 536
Lines 25562 25550 -12
=======================================
- Hits 21997 21988 -9
+ Misses 3565 3562 -3
Continue to review full report at Codecov.
|
fweik
approved these changes
Nov 15, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 15, 2019
3314: Modernize core r=fweik a=jngrad Follow-up to #3304 Description of changes: - cherry-pick #3312 - add a `BoxGeometry::volume` method - use `bool` for true/false flags - reduce scope of local variables - remove obsolete comments Co-authored-by: Christoph Junghans <[email protected]> Co-authored-by: Jean-Noël Grad <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3304
Description of changes:
BoxGeometry::volumemethodboolfor true/false flags