Fix broken python tests and refactor assertions #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DPD stress tensor is zero when kT=0, and recalc_forces=True doesn't recalculate velocities. Other tests were malformed.
Codecov Report
@@ Coverage Diff @@
## python #3419 +/- ##
======================================
- Coverage 86% 86% -1%
======================================
Files 538 538
Lines 25282 25282
======================================
- Hits 21804 21797 -7
- Misses 3478 3485 +7
Continue to review full report at Codecov.
|
jngrad
force-pushed
the
fix-python-tests
branch
from
35dc4da
to
35a6328
Compare
Use specialized assertions in place of `assertTrue` to pretty print values with a meaningful error message. Use `assertAlmostEqual(obs, ref, delta=tol)` in place of `self.assertLess(abs(obs - ref), tol)` for the same reason. Use `numpy.testing` assertions for arrays. Factor out duplicated code and simplify test logic. Remove debug print statements and a few redundant custom messages in assertions.
jngrad
force-pushed
the
fix-python-tests
branch
from
35a6328
to
2fad54c
Compare
fweik
approved these changes
Jan 18, 2020
|
We can't merge it yet, the modified dpd test is timing out on arm64. I'll have a look. Probably just a matter of removing one of the tested |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.