Cleanup cython #3496
Merged
Cleanup cython #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cython bug was resolved in v0.26, which we now require.
The runtime error interface is also defined in espressomd.utils, which is already imported by integrate.pyx.
Only import what is used. Make a consistent use of `cimport` for functions/classes declared in .pxd files (even if the body is defined in the .pyx file) and `import` for functions/classes declared in .pyx files. `cimport` statements in .pxd files must also appear in the corresponding .pyx file.
These imports were unnecessary, one had a circular dependency.
Replace wildcard imports by explicit imports. Remove unused imports. Use relative imports.
Remove non-existent global variables. Remove global variables from globals.pxd if they have already been declared in other .pxd files.
fweik
approved these changes
Feb 17, 2020
|
Don't merge yet, there is a failure in CI. |
Codecov Report
@@ Coverage Diff @@
## python #3496 +/- ##
======================================
- Coverage 87% 87% -1%
======================================
Files 536 536
Lines 24402 24404 +2
======================================
- Hits 21256 21252 -4
- Misses 3146 3152 +6
Continue to review full report at Codecov.
|
Merged
kodiakhq bot
added a commit
that referenced
this pull request
Feb 19, 2020
Follow-up to #3496 Reflect in the Python interface all dependency inversions that recently took place in the core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
globals.pxd