Opengl rasterization for union #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for shapes for brute-force rasterization.
fweik
approved these changes
Feb 24, 2020
KaiSzuttor
commented
Feb 24, 2020
| @@ -66,6 +67,14 @@ class Union : public Shape { | |||
| dist_compare); | |||
| } | |||
|
|
|||
| bool is_inside(Utils::Vector3d const &pos) const override { | |||
There was a problem hiding this comment.
@fweik this override is necessary if the union shape is used in a LB boundary.
fweik
suggested changes
Feb 24, 2020
src/core/shapes/Union.hpp
Outdated
| @@ -66,6 +67,14 @@ class Union : public Shape { | |||
| dist_compare); | |||
| } | |||
|
|
|||
| bool is_inside(Utils::Vector3d const &pos) const override { | |||
| return boost::accumulate( | |||
There was a problem hiding this comment.
I think you should use any_of, which will short-cut and makes the intent clearer.
There was a problem hiding this comment.
you probably mean all_of
KaiSzuttor
force-pushed
the
opengl_rasterization
branch
from
9d3f13a
to
07940a5
Compare
KaiSzuttor
force-pushed
the
opengl_rasterization
branch
from
07940a5
to
7279340
Compare
Codecov Report
@@ Coverage Diff @@
## python #3538 +/- ##
======================================
- Coverage 87% 87% -1%
======================================
Files 536 536
Lines 24180 24146 -34
======================================
- Hits 21066 21014 -52
- Misses 3114 3132 +18
Continue to review full report at Codecov.
|
|
i will provide a test for LB boundary using the union shape which will make codecov happy |
fweik
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.