Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shapes: Fixed SpheroCylinder outside condition. #3629

Merged
merged 2 commits into from
Apr 4, 2020
Merged

shapes: Fixed SpheroCylinder outside condition. #3629

merged 2 commits into from
Apr 4, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Apr 3, 2020

There is obviously a test missing, but I think this is what is actually intended.

@fweik fweik requested a review from jngrad April 3, 2020 19:10
@fweik fweik mentioned this pull request Apr 3, 2020
Closed
@jngrad jngrad added this to the Espresso 4.1.3 milestone Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #3629 into python will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3629   +/-   ##
======================================
- Coverage      87%     87%   -1%     
======================================
  Files         524     524           
  Lines       23471   23471           
======================================
- Hits        20654   20649    -5     
- Misses       2817    2822    +5
Impacted Files Coverage Δ
src/core/particle_data.cpp 95% <0%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 85% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2836bd...659b2bf. Read the comment docs.

@fweik fweik added the automerge Merge with kodiak label Apr 3, 2020
@kodiakhq kodiakhq bot merged commit eba788a into espressomd:python Apr 4, 2020
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Jul 4, 2020
@kodiakhq @RudolfWeeber
shapes: Fixed SpheroCylinder outside condition. (espressomd#3629)
0fea039 
There is obviously a test missing, but I *think* this is what is actually intended.
@fweik fweik deleted the sphero_cylinder branch August 27, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Core
Projects
None yet
Milestone
Espresso 4.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@fweik @jngrad