Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBCPU: Fix rounding issue for grid size calculation #3678

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

RudolfWeeber
Copy link
Contributor

Description of changes:
Replaces ceil by round in lbcpu n*agrid ~= box_l calculation + a test in which the old behavior resulted in a false positive

@fweik
Copy link
Contributor

fweik commented Apr 21, 2020

The Lattice class is a gift that just keeps on giving...

fweik
fweik previously approved these changes Apr 21, 2020
@fweik fweik self-assigned this Apr 21, 2020
@fweik fweik added BugFix Core automerge Merge with kodiak labels Apr 21, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #3678 into python will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3678    +/-   ##
=======================================
  Coverage      87%     87%            
=======================================
  Files         526     536    +10     
  Lines       21987   22758   +771     
=======================================
+ Hits        19301   20014   +713     
- Misses       2686    2744    +58     
Impacted Files Coverage Δ
src/core/grid_based_algorithms/lattice.cpp 88% <100%> (+<1%) ⬆️
src/core/EspressoSystemInterface.hpp 48% <0%> (-19%) ⬇️
src/core/polymer.cpp 92% <0%> (-6%) ⬇️
src/core/particle_data.cpp 96% <0%> (-1%) ⬇️
src/script_interface/lbboundaries/LBBoundary.hpp 100% <0%> (ø)
...e/virtual_sites/VirtualSitesInertialessTracers.cpp 100% <0%> (ø)
.../grid_based_algorithms/lbboundaries/LBBoundary.hpp 100% <0%> (ø)
src/core/actor/Actor.hpp 100% <0%> (ø)
src/core/actor/DipolarDirectSum.cpp 100% <0%> (ø)
src/core/CudaHostAllocator.hpp 100% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae36c6f...6986c2a. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 08dd194 into espressomd:python Apr 21, 2020
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Jul 4, 2020
Description of changes:
Replaces ceil by round in lbcpu n*agrid ~= box_l calculation + a test in which the old behavior resulted in a false positive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants