Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observables and correlators/accumulators maintainance #3781

Merged
merged 8 commits into from
Jun 27, 2020
Merged

Observables and correlators/accumulators maintainance #3781

merged 8 commits into from
Jun 27, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jun 27, 2020

Description of changes:

  • fix broken tensor_product correlator (only returned zeros in 4.1)
  • add more correlators and accumulators test cases
  • test script interface getters/setters for observables, correlators and accumulators
  • make code coverage more reproducible

@jngrad
Increase coverage of stochastic tests
421928c 
Check draw_polymer_positions() with a high rejection rate and
UpdateOrientation::serialize() (only called on MPI ranks != 0).

When conditional branches depend on random values, the global code
coverage can fluctuate between CI pipelines. Testing more branches
(usually those with runtime errors in stochastic functions) will
decrease the probability of commits randomly changing code coverage
by 1% when the source code did not actually change.
@jngrad
testsuite: Fix coding style and add tearDown()
e11de94
@jngrad
observables: Increase script interface coverage
586f65f
@jngrad
core: Fix broken tensor_product correlator
c035e2e 
The regression was introduced in 4.1.0.
@jngrad
core: Use const arguments in correlator kernels
23ab645
@jngrad
correlators: Add tests
17da023
@jngrad
correlators: Increase script interface coverage
427398e
@jngrad jngrad added this to the Espresso 4.1.3 milestone Jun 27, 2020
@codecov
Copy link

codecov bot commented Jun 27, 2020 •
edited
Loading

Codecov Report

Merging #3781 into python will increase coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3781    +/-   ##
=======================================
+ Coverage      87%     88%    +1%     
=======================================
  Files         552     552            
  Lines       24446   24446            
=======================================
+ Hits        21391   21712   +321     
+ Misses       3055    2734   -321
Impacted Files Coverage Δ
src/core/accumulators/Correlator.hpp 90% <ø> (ø)
src/core/accumulators/Correlator.cpp 72% <100%> (+6%) ⬆️
src/core/electrostatics_magnetostatics/p3m.cpp 87% <0%> (-1%) ⬇️
src/core/particle_data.cpp 96% <0%> (+<1%) ⬆️
src/core/polymer.cpp 100% <0%> (+7%) ⬆️
src/core/observables/RDF.hpp 100% <0%> (+22%) ⬆️
src/script_interface/accumulators/TimeSeries.hpp 91% <0%> (+24%) ⬆️
src/script_interface/observables/PidObservable.hpp 100% <0%> (+27%) ⬆️
.../script_interface/accumulators/AccumulatorBase.hpp 100% <0%> (+42%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe8c73...816e7b0. Read the comment docs.

@jngrad jngrad marked this pull request as ready for review June 27, 2020 17:43
@fweik fweik added the automerge Merge with kodiak label Jun 27, 2020
@kodiakhq kodiakhq bot merged commit 9cc0cd1 into espressomd:python Jun 27, 2020
@jngrad jngrad deleted the increase-coverage branch January 18, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fweik fweik fweik approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Testcase
Projects
None yet
Milestone
Espresso 4.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @fweik