Fix bugs in espressomd.analyze module #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is unused, untested and undocumented.
The analysis.structure_factor() method could count particles twice when the corresponding particle type appeared twice in the sf_types argument.
Use r_max + 1 as the initial minimal distance instead of an arbitrary value when calculating the RDF of the minimal distance with r_max larger than the box size.
reinaual
approved these changes
Jul 18, 2022
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Nov 28, 2022
Description of changes: - fix particle double-counting bug in the structure factor analysis code - fix distance calculation bug in the particle distribution analysis code when `r_max > np.sum(system.box_l)` - remove unused v_kappa analysis code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
r_max > np.sum(system.box_l)