Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs in dipolar direct sum on gpu #456

Merged
merged 4 commits into from
Nov 10, 2015

Conversation

RudolfWeeber
Copy link
Contributor

  1. Avoid invalid frees
  2. Missing Bjerum length (From B.M Tanygin, pull request Rotational motion core fixes: adding mass and dimensionless model related parameters #453
  3. Testcase comparing dipolar direct summation methods against each other and checking the scaling with Bjerrum length

@codecov-io
Copy link

Current coverage is 27.85%

Merging #456 into master will not affect coverage as of 81d9139

@@            master    #456   diff @@
======================================
  Files          275     275       
  Stmts        65805   65577   -228
  Branches         0       0       
  Methods          0       0       
======================================
- Hit          18331   18269    -62
  Partial          0       0       
+ Missed       47474   47308   -166

Review entire Coverage Diff as of 81d9139

Powered by Codecov. Updated on successful CI builds.

fweik added a commit that referenced this pull request Nov 10, 2015
Fixes bugs in dipolar direct sum on gpu
@fweik fweik merged commit d268bbb into espressomd:master Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants