Fix unit tests environment variables #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AMD Ryzen and AMD EPYC, Open MPI version 4.x does not properly work in singleton mode if the MCA binding policy is set to "numa". Print a harmless warning in pypresso/ipypresso if the CPU is affected to help users troubleshoot the ORTE error message.
jngrad
force-pushed
the
openmpi_guards
branch
from
2ba7dff
to
1da59fe
Compare
reinaual
approved these changes
Nov 21, 2022
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Nov 30, 2022
Description of changes: - properly set unit test environment variables related to sanitizers - address Open MPI version 4.x singleton mode bug on NUMA architectures - disable MCA binding policy on unit tests running in singleton mode on affected NUMA architectures - print a warning in pypresso when running in singleton mode on affected NUMA architectures (can be disabled with a CMake option)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: