Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed system.part.pairs() #4628

Merged
merged 2 commits into from
Dec 12, 2022
Merged

fixed system.part.pairs() #4628

merged 2 commits into from
Dec 12, 2022

Conversation

Koppeprojects
Copy link

@Koppeprojects Koppeprojects commented Dec 12, 2022 •
edited by jngrad
Loading

Fixes #4622

Description of changes:

  • the System.part.pairs() method now returns the correct particle pairs when particle ids aren't both contiguous and starting from 0

jngrad
jngrad approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jngrad jngrad added this to the Espresso 4.2.1 milestone Dec 12, 2022
@jngrad jngrad added Python BugFix automerge Merge with kodiak labels Dec 12, 2022
@kodiakhq kodiakhq bot merged commit 466d54b into espressomd:python Dec 12, 2022
jngrad pushed a commit to jngrad/espresso that referenced this pull request Dec 23, 2022
@kodiakhq @jngrad
fixed system.part.pairs() (espressomd#4628)
8e171fb 
Fixes espressomd#4622

Description of changes:
- the `System.part.pairs()` method now returns the correct particle pairs when particle ids aren't both contiguous and starting from 0
jngrad pushed a commit to jngrad/espresso that referenced this pull request Dec 23, 2022
@kodiakhq @jngrad
fixed system.part.pairs() (espressomd#4628)
2807fd7 
Fixes espressomd#4622

Description of changes:
- the `System.part.pairs()` method now returns the correct particle pairs when particle ids aren't both contiguous and starting from 0
jngrad pushed a commit to jngrad/espresso that referenced this pull request Dec 23, 2022
@kodiakhq @jngrad
fixed system.part.pairs() (espressomd#4628)
19c7a54 
Fixes espressomd#4622

Description of changes:
- the `System.part.pairs()` method now returns the correct particle pairs when particle ids aren't both contiguous and starting from 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Python
Projects
None yet
Milestone
Espresso 4.2.1
Development

Successfully merging this pull request may close these issues.

Py: system.part.pairs() is wrong
2 participants
@Koppeprojects @jngrad