Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script_interface: Fix dict_keys-list merge bug #4674

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

RiccardoFrenner
Copy link
Contributor

Fixes #4673

Description of changes:

  • Convert dict_keys to list before trying to concatenate with a list

@RiccardoFrenner RiccardoFrenner changed the title script_interface: Fix dict_keys, list merge bug script_interface: Fix dict_keys-list merge bug Feb 19, 2023
@jngrad jngrad added this to the Espresso 4.2.1 milestone Feb 20, 2023
@jngrad jngrad added the automerge Merge with kodiak label Feb 20, 2023
@kodiakhq kodiakhq bot merged commit a824a7d into espressomd:python Feb 20, 2023
jngrad pushed a commit to jngrad/espresso that referenced this pull request Mar 2, 2023
Fixes espressomd#4673 

Description of changes:
- Convert `dict_keys` to list before trying to concatenate with a list
jngrad pushed a commit to jngrad/espresso that referenced this pull request Mar 2, 2023
Fixes espressomd#4673 

Description of changes:
- Convert `dict_keys` to list before trying to concatenate with a list
jngrad pushed a commit to jngrad/espresso that referenced this pull request Mar 2, 2023
Fixes espressomd#4673 

Description of changes:
- Convert `dict_keys` to list before trying to concatenate with a list
jngrad pushed a commit to jngrad/espresso that referenced this pull request Mar 2, 2023
Fixes espressomd#4673 

Description of changes:
- Convert `dict_keys` to list before trying to concatenate with a list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling the dir method on a ScriptInterfaceHelper object raises a TypeError
2 participants