Fix inertialess tracers #4714
Merged
Fix inertialess tracers #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the Euler integrator update the position along all coordinates, not just the x- and y-axes. Adapt the test case to check all three coordinates are properly integrated. This fixes the regression introduced by 29cf77d.
The LB GPU method silently skips inertialess tracers on non-root MPI ranks. Now an exception is raised.
jngrad
force-pushed
the
fix-inertialess-tracers
branch
from
cc1a72f
to
c7f45ae
Compare
RudolfWeeber
approved these changes
Apr 26, 2023
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Jul 13, 2023
Description of changes: - bugfix: inertialess tracers are now integrated along the z-axis (regression introduced in February 2022) - bugfix: a runtime exception is now raised when using more than 1 MPI rank with inertialess tracers + LB GPU - with LB GPU, inertialess tracers are silently skipped on MPI ranks >= 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: