Address API change in Python 3.12 unittest module #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Python 3.12, package unittest returns exit code 5 when all tests are skipped. This exit code is now ignored by CTest.
|
This fix was backported to 4.2.1 on Fedora and all tests passed with Python 3.12 (Koji task 112216357). |
|
Update submitted to Bohdi: espresso-4.2.1-10.fc40. |
|
Bugzilla ticket 2259563 closed as resolved. |
reinaual
approved these changes
Jan 30, 2024
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Feb 29, 2024
Starting with Python 3.12, package `unittest` returns exit code 5 when all tests are skipped. By default, CTest treats any non-zero exit code as a failure. This can be remediated by setting test property [`SKIP_RETURN_CODE`](https://cmake.org/cmake/help/latest/prop_test/SKIP_RETURN_CODE.html) to 5. Description of changes: - skipped tests are no longer treated as failures by CTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Python 3.12, package
unittestreturns exit code 5 when all tests are skipped. By default, CTest treats any non-zero exit code as a failure. This can be remediated by setting test propertySKIP_RETURN_CODEto 5.Description of changes: