Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages: Use large font for message body when message < 2 lines #1400

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Messages: Use large font for message body when message < 2 lines #1400

merged 2 commits into from
Feb 7, 2022

Conversation

lightnin
Copy link
Contributor

@lightnin lightnin commented Feb 6, 2022

In: #1294 (comment), @gfwilliams said:
"Right now the message title font does change dynamically depending on how much text there is, so doing the same for the body text is probably no big deal."

This mirrors the implementation used for the message title in the message body.

I can see there are other issues open related to controlling font size globally. But I think the main need for most users will be in the messages app, where the ability to choose a larger font for body text would be useful even in the short term, IMHO. Perhaps getting rid of the buttons in favor of labels to view next / previous via swipe direction would leave more screen real estate for larger text as well. The buttons do not work for me most of the time.
As always - thanks for making this great ecosystem!

@lightnin
Copy link
Contributor Author

lightnin commented Feb 6, 2022

I realized after the first submission that two lines of large text will fit nicely on Bangle.js 2's screen. So now it checks to see if the message body will fit on two lines of text w/ large font, and only decreases font size if message is larger than that.

@lightnin lightnin changed the title When message app message body is < 1 line wide w/ large font, use large font. Messages: Use large font for message body when message < 2 lines Feb 6, 2022
@gfwilliams
Copy link
Member

This looks excellent - thanks!

And yes, swipe was suggested as a way to remove the buttons. I've been meaning to think about that as I think we need something to show users that swiping does something, but otherwise it makes a lot of sense (and button for back)

@gfwilliams
Copy link
Member

Sorry - one more thing - when you make changes, please can you add a line to the changelog and bump the version number in metadata.json - I'll do that now though

@gfwilliams gfwilliams merged commit 14986d6 into espruino:master Feb 7, 2022
@lightnin
Copy link
Contributor Author

lightnin commented Feb 7, 2022

Sorry - one more thing - when you make changes, please can you add a line to the changelog and bump the version number in metadata.json - I'll do that now though

Yes! I would have done but wasn't sure if the patch would likely get merged in to a release with other patches. I will in future. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants