Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networking: Even if HTTPS isn't compiled in, set type|=ST_TLS #2410

Open
gfwilliams opened this issue Sep 8, 2023 · 2 comments
Open

networking: Even if HTTPS isn't compiled in, set type|=ST_TLS #2410

gfwilliams opened this issue Sep 8, 2023 · 2 comments

Comments

@gfwilliams
Copy link
Member

By figuring out when to set the type, we can allow networkjs implementations to ask the wifi/etc module to handle HTTPS for us.

Right now doing it is very hacky (involving looking at the 4th 'options' argument to connect)
@gfwilliams
Copy link
Member Author

gfwilliams commented Sep 8, 2023 •
edited
Loading

Needed to avoid this hack espruino/EspruinoDocs@c9045a2

gfwilliams added a commit that referenced this issue Oct 10, 2024
@gfwilliams
Network: enable parsing of 'https' URL and TLS flag even even TLS not…
0c89774 
… built in (#2410)
@gfwilliams
Copy link
Member Author

This is in now, but the ESP8266Wifi module needs updating and testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gfwilliams