Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildmodules.sh in now javascript script build file #706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brendena
Copy link
Contributor

I moved the build buildmodules.sh script into javascript file ./bin/buildmodules.js .

command now

  • node run build_modules

Goal

  • Add the ability to build just one file via --file=./device/name
  • Simplify the build by moving more to node build cycle
  • Potentially make it run faster

@brendena
Copy link
Contributor Author

brendena commented Dec 18, 2023

Not entirely sure if this is a good change. But i coded it up.

@gfwilliams
Copy link
Member

Has minify.js just turned into a module so it can no longer be used from the command-line?

Because we use it from the Espruino repo, for instance https://github.com/espruino/Espruino/blob/master/libs/js/update_js.sh

I use buildmodules.sh from scripts here to build the main site as well, and even build.sh in this repo uses it and hasn't been updated so would break.

Thanks for this, but I'm not sure I want to pull it in I'm afraid - if you wanted to just extend buildmodules.sh to optionally handle one file I could understand, or if this added extra features, but just swapping to JS instead without really adding functionality, and in the process breaking EspruinoDocs, Espruino, and my internal tools just seems a bit too much of a stretch...

Unfortunately I'm not sure it's going to speed stuff up either - most of the heavy lifting is done in Java which would be reloeaded for every file anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants