Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker references with both a tag and digest are currently not supported #48

Closed
shaikatz opened this issue Jan 4, 2021 · 3 comments · Fixed by #194
Closed

Docker references with both a tag and digest are currently not supported #48

shaikatz opened this issue Jan 4, 2021 · 3 comments · Fixed by #194
Labels

Comments

@shaikatz
Copy link

shaikatz commented Jan 4, 2021

Hi,
Receiving the titled error when using image that includes tags and digest like k8s.gcr.io/ingress-nginx/controller:v0.43.0@sha256:9bba603b99bf25f6d117cf1235b6598c16033ad027b143c90fa5b3cc583c5713

Where this limitation is coming from? can't ECR support digest?
Can we somehow overcome that so the tool will support that?

@bradonkanyid
Copy link

I've followed this to the source and found that the upstream library won't support images with tags and digests. That issue is here: containers/image#783

CRI-O had to implement their own behavior to fix, here: cri-o/cri-o#3060

@bradonkanyid
Copy link

My mistake: here's containers/image explicitly stating they won't support this: containers/image#1019

rattboi added a commit to rattboi/k8s-image-swapper that referenced this issue May 6, 2022
fix estahn#48

This solution is taken almost directly from CRI-O, as referenced here: https://github.com/cri-o/cri-o/pull/3060/files
rattboi added a commit to rattboi/k8s-image-swapper that referenced this issue May 6, 2022
fix estahn#48

This solution is taken almost directly from CRI-O, as referenced here: https://github.com/cri-o/cri-o/pull/3060/files
estahn pushed a commit to rattboi/k8s-image-swapper that referenced this issue Jul 2, 2022
fix estahn#48

This solution is taken almost directly from CRI-O, as referenced here: https://github.com/cri-o/cri-o/pull/3060/files
estahn pushed a commit that referenced this issue Jul 2, 2022
fix #48

This solution is taken almost directly from CRI-O, as referenced here: https://github.com/cri-o/cri-o/pull/3060/files
estahn pushed a commit that referenced this issue Jul 3, 2022
# [1.2.0](v1.1.0...v1.2.0) (2022-07-03)

### Bug Fixes

* add missing dash ([228749d](228749d))
* bump alpine to 3.16 due to security reports ([f7d6564](f7d6564))
* docker references with both tag and digest ([5a17075](5a17075)), closes [#48](#48)
* failed to solve: executor failed running ([af7df18](af7df18))
* setup buildx and qemu for image-scan ([c435048](c435048))
* standard_init_linux.go:228: exec user process caused: exec format error ([b7d0c89](b7d0c89))
* **deps:** update module github.com/aws/aws-sdk-go to v1.40.54 ([7f9dbf5](7f9dbf5))

### Features

* add arm docker build ([be81815](be81815))
* add full arm support to image copying ([6f14156](6f14156))
@estahn
Copy link
Owner

estahn commented Jul 3, 2022

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@estahn estahn added the released label Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants