Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutate initContainers #73

Closed
estahn opened this issue Apr 25, 2021 · 5 comments
Closed

Mutate initContainers #73

estahn opened this issue Apr 25, 2021 · 5 comments
Assignees
@estahn
Labels
enhancement New feature or request released

Comments

@estahn
Copy link
Owner

estahn commented Apr 25, 2021 •
edited
Loading

k8s-image-swapper is currently not handling initContainers.
@estahn estahn added the enhancement New feature or request label Apr 25, 2021
@estahn estahn self-assigned this Apr 26, 2021
@asad-awadia
Copy link

@estahn #96 how does this look?

@asad-awadia
Copy link

@estahn ping

@estahn
Copy link
Owner Author

estahn commented Aug 2, 2021

@asad-awadia Thanks for the contribution. I just came back from an extended vacation and catching up with things. Will look at this shortly.

@asad-awadia
Copy link

@estahn Ok np - Lmk how the PR looks - if any changes required

@estahn estahn added this to the 1.1.0 milestone Aug 16, 2021
@estahn estahn changed the title Handle initContainers Mutate initContainers Aug 16, 2021
@estahn estahn mentioned this issue Aug 16, 2021
Closed
@estahn estahn linked a pull request Aug 16, 2021 that will close this issue
loop over init containers as well #96
Closed
estahn added a commit that referenced this issue Oct 2, 2021
@estahn
feat: Support for pod.spec.initContainers
aa29b88 
Adding support for containers in `pod.spec.initContainers`, swapping the image
in the same way as `pod.spec.containers`.

fixes #73 #96
@estahn estahn mentioned this issue Oct 2, 2021
Merged
estahn added a commit that referenced this issue Oct 2, 2021
@estahn
feat: Support for pod.spec.initContainers (#118)
b399e05 
* feat: Support for pod.spec.initContainers

Adding support for containers in `pod.spec.initContainers`, swapping the image
in the same way as `pod.spec.containers`.

fixes #73 #96
@estahn estahn closed this as completed Oct 2, 2021
estahn added a commit that referenced this issue Oct 2, 2021
@estahn
feat: Support for pod.spec.initContainers (#118)
725ff2c 
* feat: Support for pod.spec.initContainers

Adding support for containers in `pod.spec.initContainers`, swapping the image
in the same way as `pod.spec.containers`.

fixes #73 #96
github-actions bot pushed a commit that referenced this issue Oct 2, 2021
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
a0b2506 
# [1.1.0](v1.0.0...v1.1.0) (2021-10-02)

### Bug Fixes

* provide log record for ImageSwapPolicyExists ([179da70](179da70))
* timeout for ECR client ([26bdc10](26bdc10))
* **deps:** update module github.com/alitto/pond to v1.5.1 ([504e2dd](504e2dd))
* **deps:** update module github.com/aws/aws-sdk-go to v1.38.47 ([#70](#70)) ([4f30053](4f30053))
* **deps:** update module github.com/aws/aws-sdk-go to v1.40.43 ([266ef01](266ef01))
* **deps:** update module github.com/containers/image/v5 to v5.11.0 ([#61](#61)) ([11d6d28](11d6d28))
* **deps:** update module github.com/containers/image/v5 to v5.16.0 ([5230b91](5230b91))
* **deps:** update module github.com/dgraph-io/ristretto to v0.1.0 ([#82](#82)) ([dff1cb1](dff1cb1))
* **deps:** update module github.com/go-co-op/gocron to v1.9.0 ([c0e9f11](c0e9f11))
* **deps:** update module github.com/rs/zerolog to v1.22.0 ([#76](#76)) ([c098326](c098326))
* **deps:** update module github.com/rs/zerolog to v1.23.0 ([#84](#84)) ([607d5bb](607d5bb))
* **deps:** update module github.com/rs/zerolog to v1.25.0 ([72822f4](72822f4))
* **deps:** update module github.com/slok/kubewebhook to v2 ([8bd73d4](8bd73d4))
* **deps:** update module github.com/spf13/cobra to v1.2.1 ([ea1e787](ea1e787))
* **deps:** update module github.com/spf13/viper to v1.8.1 ([8a055a2](8a055a2))
* **deps:** update module k8s.io/api to v0.22.1 ([ab6d898](ab6d898))
* **deps:** update module k8s.io/apimachinery to v0.21.1 ([#79](#79)) ([aeeeffb](aeeeffb))
* **deps:** update module k8s.io/apimachinery to v0.22.2 ([ef72c66](ef72c66))

### Features

* Support for imagePullSecrets ([#112](#112)) ([2d8cf77](2d8cf77)), closes [#92](#92) [#19](#19)
* Support for pod.spec.initContainers ([#118](#118)) ([725ff2c](725ff2c)), closes [#73](#73) [#96](#96)
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2021

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estahn estahn

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

loop over init containers as well asad-awadia/k8s-image-swapper
2 participants
@estahn @asad-awadia