source-zendesk-support: update capture snapshot #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over the weekend, it looks like Zendesk Support added a `configuration.explore_reports` field to all custom roles returned via their API. This is causing our `source-zendesk-support` capture snapshot test to fail, so updating the snapshot will let our tests pass. Since `configuration.explore_reports` isn't included in the official Zendesk Support docs yet, I'm holding off on adding that field to the stream's schema in case Zendesk removes it.
Alex-Bair
added
the
change:unplanned
williamhbaker
approved these changes
Sep 30, 2024
Alex-Bair
added a commit
that referenced
this pull request
Oct 2, 2024
Zendesk Support's API is no longer returning the `configuration.explore_reports` field for custom roles. This reverts the snapshot change done in PR #1991.
Alex-Bair
added a commit
that referenced
this pull request
Oct 2, 2024
Zendesk Support's API is no longer returning the `configuration.explore_reports` field for custom roles. This reverts the snapshot change done in PR #1991.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Over the weekend, it looks like Zendesk Support added a
configuration.explore_reportsfield to all custom roles returned via their API. This is causing oursource-zendesk-supportcapture snapshot test to fail, so updating the snapshot will let our tests pass. This is preventing the build for #1988 from succeeding (tests passed Friday for the PR, but they didn't pass this morning when I merged 😓).Since
configuration.explore_reportsisn't included in the official Zendesk Support docs yet, I'm holding off on adding that field to the stream's schema in case Zendesk removes it.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Ensured tests passed locally after updating the snapshot.
This change is