Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-zendesk-support: fix Groups and Organizations streams #2007

Merged
merged 2 commits into from
Oct 2, 2024
Merged

source-zendesk-support: fix Groups and Organizations streams #2007

merged 2 commits into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. source-zendesk-support: include deleted groups in Groups stream

    @Alex-Bair
    Alex-Bair committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    01c87f1 View commit details
    Browse the repository at this point in the history

  2. source-zendesk-support: switch Organizations stream to use incrementa… 

    …l time-based export

The Organizations stream was previously using page numbers to retrieve
results from Zendesk. This is an older pagination method for Zendesk
Support, and we can only retrieve 10,000 documents using this endpoint.
After 10k documents, Zendesk cuts us off. This meant that we weren't
retrieving all organizations for users with more than 10k organizations.

We can switch the Organizations stream to use "time-based" incremental
exports. Instead of a page number, we use a specific start time to
request all organizations that have been updated at or after that start
time. Using this pagination strategy does have the potential downside of
getting stuck in a loop if 1000+ organizations are updated at the exact
same time, but there are not currently better ways to retrieve
incremental updates for organizations.

The new `SourceZendeskSupportIncrementalTimeExportStream` is an
improvement on the existing `SourceZendeskSupportIncrementalExportStream`
in almost every way. At a later date, we could consider refactoring out
`SourceZendeskSupportIncrementalExportStream` since the new class should
serve the same purpose even better. Doing so would require a lot of time
intensive refactoring & inheritance un-tangling that are so I've
left that for future work.
    @Alex-Bair
    Alex-Bair committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    387feb6 View commit details
    Browse the repository at this point in the history