source-kafka: extend metadata timeout #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This timeout is used for fetching cluster metadata during the interactive discover and validation operations. We need some kind of timeout here since its not uncommon for misconfigured configurations to end up hanging forever when trying to connect, but it can also take a little while for all the metadata to be returned from a Kafka cluster if there is a lot of it. This extends the timeout from a pretty restrictive 5 seconds to a much more permissive 60 seconds. 60 seconds is quite a while for a discover/validate attempt to hang if the configuration is incorrect but that seems like a better direction to err on than failing correct configurations too soon for particularly large clusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This timeout is used for fetching cluster metadata during the interactive discover and validation operations.
We need some kind of timeout here since its not uncommon for misconfigured configurations to end up hanging forever when trying to connect, but it can also take a little while for all the metadata to be returned from a Kafka cluster if there is a lot of it.
This extends the timeout from a pretty restrictive 5 seconds to a much more permissive 60 seconds. 60 seconds is quite a while for a discover/validate attempt to hang if the configuration is incorrect but that seems like a better direction to err on than failing correct configurations too soon for particularly large clusters.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is