Skip to content

Commit

Permalink
pythongh-119819: Conditional skip of logging tests that require multi…
Browse files Browse the repository at this point in the history
…processing subprocess support (python#120476)

Skip tests that require multiprocessing subprocess support.
  • Loading branch information
freakboy3742 authored and estyxx committed Jul 17, 2024
1 parent fec0301 commit 1d65c11
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions Lib/test/test_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -3898,6 +3898,7 @@ def do_queuehandler_configuration(self, qspec, lspec):
self.addCleanup(os.remove, fn)

@threading_helper.requires_working_threading()
@support.requires_subprocess()
def test_config_queue_handler(self):
q = CustomQueue()
dq = {
Expand Down Expand Up @@ -3926,12 +3927,10 @@ def test_config_queue_handler(self):
msg = str(ctx.exception)
self.assertEqual(msg, "Unable to configure handler 'ah'")

@support.requires_subprocess()
def test_multiprocessing_queues(self):
# See gh-119819

# will skip test if it's not available
import_helper.import_module('_multiprocessing')

cd = copy.deepcopy(self.config_queue_handler)
from multiprocessing import Queue as MQ, Manager as MM
q1 = MQ() # this can't be pickled
Expand Down

0 comments on commit 1d65c11

Please sign in to comment.