Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add refresh option in apify endpoint #159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

geoffreyaldebert
Copy link
Contributor

No description provided.

@geoffreyaldebert
Copy link
Contributor Author

Propose a solution for datagouv/data.gouv.fr#957

Copy link

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! What do you think would be the strategy to use refresh on the caller side?

@@ -159,6 +159,18 @@ async def test_apify(rmock, csv, client):
assert db_path.exists()


async def test_apify_refresh(rmock, csv, client):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it actually tests the refresh feature though? You should make two call, with a different mock on the second one right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants