goreleaser based release build #136
Conversation
bavarianbidi
force-pushed
the
enable_release_build
branch
from
1d0097b
to
43dd0f5
Compare
There was a problem hiding this comment.
Hi @bavarianbidi, thanks for your pull request!
A question is whether we should go the gorelease way (with GitHub actions), which strives away from our effort of migrating the GitHub actions to the prow infrastructure.
I'm not sure if the workflow will work because, as we experienced before, we don't have write permission in the repositories.
I left some comments on the pull request (although I'm not familiar with auguer). One thing that I also noticed is that I suggest breaking this pull request into two. One addressing the changes to the Makefile, and another for introducing goreleaser. That way, we can squash commits, and we don't have multi-purpose commits in the same PR :)
Thoughts on this approach, @jmhbnz?
bavarianbidi
force-pushed
the
enable_release_build
branch
from
43dd0f5
to
dc9a2fd
Compare
There was a problem hiding this comment.
LGTM - Thanks @bavarianbidi
cc @ivanvc can you please also review once more before we merge.
There was a problem hiding this comment.
LGTM. I'm leaving two open questions, but I'm fine if they're addressed in follow-up pull requests. Thanks, @bavarianbidi.
releases will be done via goreleaser. It will also add a version subcommand to auger and augerctl Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
bavarianbidi
force-pushed
the
enable_release_build
branch
from
6e6bce3
to
cb5a758
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bavarianbidi, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes #28
This will add a
goreleaserbased release process as described in the updatedRELEASE.mdAn example release with artifacts can be seen here: https://github.com/bavarianbidi/auger/releases/tag/v0.1.0
https://github.com/bavarianbidi/auger/actions/runs/11392186824/job/31697673348 will give you the github actions output of the release process, produced by
goreleaser.