Avoid syscall.Syscall use on OpenBSD #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
force-pushed
the
openbsd_libc_msync
branch
from
069ac48
to
90a1d44
Compare
ptabor
approved these changes
Feb 11, 2023
Syscall numbers are not stable on OpenBSD, and hardcoding the msync syscall number will break bbolt on future versions of OpenBSD. Use the libc wrapper provided by golang.org/x/sys/unix instead. Signed-off-by: Josh Rickmar <[email protected]>
jrick
force-pushed
the
openbsd_libc_msync
branch
from
90a1d44
to
f5e8ebe
Compare
|
Thanks @jrick for the PR, which looks good to me. But have you tested it on OpenBSD? |
|
I have. It works the same as before (which is not perfect, there is a known bug in the kernel that the bbolt tests are exposing). |
Could you be more specific on this and paste the error the test exposed so that we can reference? |
|
See this thread: https://marc.info/?t=166694295600001&r=1&w=2 |
|
Thanks. |
|
To add to the sense of urgency, __syscall(2) is being removed now, and syscall(2) is planned to be removed shortly after 7.3 is released. |
|
@jrick could you please backport this PR to release-1.3? |
Done: #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syscall numbers are not stable on OpenBSD, and hardcoding the msync syscall number will break bbolt on future versions of OpenBSD. Use the libc wrapper provided by golang.org/x/sys/unix instead.
This fix can be confirmed by ktrace and kdump, which on OpenBSD -current, reports whether a syscall is made through syscall(2) or not. Before:
And after: