Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Bump go version to 1.22.8 #837

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

PyAgni
Copy link
Contributor

@PyAgni PyAgni commented Oct 2, 2024

@ahrtr ahrtr changed the title Bump go version to 1.22.8 [1.3] Bump go version to 1.22.8 Oct 2, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Can you split the commit into two, one for the golangcli-lint version update and another for Golang's?

Same applies to #836

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split the commit into two, one for the golangcli-lint version update and another for Golang's?

Yes, I agree. But I won't insist on it for such minor changes, and we won't update the changelog for either change.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #837 (comment), this LGTM. Thanks, Agni.

@ivanvc ivanvc mentioned this pull request Oct 4, 2024
@ivanvc
Copy link
Member

ivanvc commented Oct 4, 2024

Quick question, @ahrtr: did you manually approve the workflows for the pull request? I see it skipped the ok-to-test label, but I'm unsure why the tests ran.

@ahrtr
Copy link
Member

ahrtr commented Oct 4, 2024

Quick question, @ahrtr: did you manually approve the workflows for the pull request?

Yes, maintainers need to manually trigger workflow for first-time contributors. Please feel free to introduce ok-to-test mechanism to bbolt if you have time. thx

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, PyAgni

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e79ff94 into etcd-io:release-1.3 Oct 4, 2024
10 checks passed
@ivanvc
Copy link
Member

ivanvc commented Oct 7, 2024

Yes, maintainers need to manually trigger workflow for first-time contributors. Please feel free to introduce ok-to-test mechanism to bbolt if you have time. thx

I forgot to follow up on this comment. We have it in place (#638), but I'm not sure why every new PR in the etcd repo has the needs-ok-to-test and not here.

@ahrtr
Copy link
Member

ahrtr commented Oct 8, 2024

I forgot to follow up on this comment. We have it in place (#638), but I'm not sure why every new PR in the etcd repo has the needs-ok-to-test and not here.

It seems that you did not get release-1.3 included in the list?

branches:
- main

@ivanvc
Copy link
Member

ivanvc commented Oct 8, 2024

It seems that you did not get release-1.3 included in the list?

Good catch. I'll open a PR and move the conversation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants