Skip to content

Commit

Permalink
Merge pull request #18603 from lekaf974/feat/rename-module-exp
Browse files Browse the repository at this point in the history
Rename modules_exp to modules_for_bom to improve code and clarity
  • Loading branch information
serathius authored Sep 19, 2024
2 parents 2ed418c + 5b2faec commit ce07474
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion scripts/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ function bom_pass {
log_callout "Checking bill of materials..."
# https://github.com/golang/go/commit/7c388cc89c76bc7167287fb488afcaf5a4aa12bf
# shellcheck disable=SC2207
modules=($(modules_exp))
modules=($(modules_for_bom))

# Internally license-bill-of-materials tends to modify go.sum
run cp go.sum go.sum.tmp || return 2
Expand Down
2 changes: 1 addition & 1 deletion scripts/test_lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ function modules() {
echo "${modules[@]}"
}

function modules_exp() {
function modules_for_bom() {
for m in $(modules); do
echo -n "${m}/... "
done
Expand Down
2 changes: 1 addition & 1 deletion scripts/updatebom.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function bom_fixlet {

local modules
# shellcheck disable=SC2207
modules=($(modules_exp))
modules=($(modules_for_bom))

if GOFLAGS=-mod=mod run_go_tool "github.com/appscodelabs/license-bill-of-materials" \
--override-file ./bill-of-materials.override.json \
Expand Down

0 comments on commit ce07474

Please sign in to comment.