etcdserver: don't let InternalAuthenticateRequest have password (#11818)

etcd-io · May 6, 2020 · feb5629 · feb5629
1 parent 035e1db
commit feb5629
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/etcdserver/v3_server.go b/etcdserver/v3_server.go
@@ -441,9 +441,10 @@ func (s *EtcdServer) Authenticate(ctx context.Context, r *pb.AuthenticateRequest
 			return nil, err
 		}
 
+		// internalReq doesn't need to have Password because the above s.AuthStore().CheckPassword() already did it.
+		// In addition, it will let a WAL entry not record password as a plain text.
 		internalReq := &pb.InternalAuthenticateRequest{
 			Name:        r.Name,
-			Password:    r.Password,
 			SimpleToken: st,
 		}