Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Documentation/etcd-mixin files #12685

Closed
nate-double-u opened this issue Feb 11, 2021 · 3 comments · Fixed by #12686
Closed

Move Documentation/etcd-mixin files #12685

nate-double-u opened this issue Feb 11, 2021 · 3 comments · Fixed by #12686

Comments

@nate-double-u
Copy link
Contributor

Issue

Migrating the Documentation to the website caused the kube-prometheus build to break.

At issue in the kube-prometheus case was the removal of the Documentation/etcd-mixin files. Restoring them solved the kube-prometheus break, but as these files are in the Documentation folder they shouldn't be relied upon for builds.

Solution

Organize with the kube-prometheus and remove the Documentation/etcd-mixin from the Documentation folder.

@nate-double-u
Copy link
Contributor Author

/cc @underrun @rohitdurvasula @spzala

@ptabor
Copy link
Contributor

ptabor commented Feb 11, 2021

https://github.com/etcd-io/etcd/tree/master/contrib looks like a place for this-type of 'integration' code.

@paulfantom
Copy link
Contributor

Hi, kube-prometheus maintainer here 👋

Most projects store their mixins in jsonnet/mixin/ (for example prometheus-operator) or mixin (for example thanos) directories, but usually contrib is also a good place.

ptabor added a commit to ptabor/etcd that referenced this issue Feb 11, 2021
The mixin was moved out together with documentation.
This broke kube-prometheous: etcd-io#12685 (comment)
@ptabor ptabor linked a pull request Feb 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants