-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Documentation/etcd-mixin files #12685
Comments
https://github.com/etcd-io/etcd/tree/master/contrib looks like a place for this-type of 'integration' code. |
Hi, kube-prometheus maintainer here 👋 Most projects store their mixins in |
ptabor
added a commit
to ptabor/etcd
that referenced
this issue
Feb 11, 2021
The mixin was moved out together with documentation. This broke kube-prometheous: etcd-io#12685 (comment)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
Migrating the Documentation to the website caused the kube-prometheus build to break.
At issue in the kube-prometheus case was the removal of the
Documentation/etcd-mixin
files. Restoring them solved the kube-prometheus break, but as these files are in the Documentation folder they shouldn't be relied upon for builds.Solution
Organize with the kube-prometheus and remove the Documentation/etcd-mixin from the Documentation folder.
The text was updated successfully, but these errors were encountered: