Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: never return an error for KeepAlive #7488

Closed
heyitsanthony opened this issue Mar 13, 2017 · 1 comment
Closed

clientv3: never return an error for KeepAlive #7488

heyitsanthony opened this issue Mar 13, 2017 · 1 comment
Assignees
@heyitsanthony
Labels
area/clientv3 stale
Milestone
etcd-v4.0

Comments

@heyitsanthony
Copy link
Contributor

Make it similar to Watch in that errors will be returned through a KeepAliveResponse message before closing the channel. If there's an unknown server error, kill all open channels and create a new stream on the next KeepAlive call.
@heyitsanthony heyitsanthony self-assigned this Mar 14, 2017
@heyitsanthony heyitsanthony added this to the v3.2.0 milestone Mar 14, 2017
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 13, 2017
clientv3: don't halt lease client if there is a lease error
a4b7cfa 
Fixes etcd-io#7488
@heyitsanthony heyitsanthony mentioned this issue Apr 13, 2017
Merged
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 17, 2017
clientv3: don't halt lease client if there is a lease error
97c40db 
Fixes etcd-io#7488
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 17, 2017
clientv3: don't halt lease client if there is a lease error
67f4db9 
Fixes etcd-io#7488
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 18, 2017
clientv3: don't halt lease client if there is a lease error
f11bbcf 
Fixes etcd-io#7488
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 21, 2017
clientv3: don't halt lease client if there is a lease error
de0aadb 
Fixes etcd-io#7488
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 24, 2017
clientv3: don't halt lease client if there is a lease error
ab9c3f5 
Fixes etcd-io#7488
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 24, 2017
clientv3: don't halt lease client if there is a lease error
2cd7108 
Fixes etcd-io#7488
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 25, 2017
clientv3: don't halt lease client if there is a lease error
747f7d0 
Fixes etcd-io#7488
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 25, 2017
clientv3: don't halt lease client if there is a lease error
ca6668d 
Fixes etcd-io#7488
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Apr 25, 2017
clientv3: don't halt lease client if there is a lease error
d5f414f 
Fixes etcd-io#7488
@mwf mwf mentioned this issue May 2, 2017
Closed
@heyitsanthony heyitsanthony modified the milestones: v4.0.0, v3.2.0 May 2, 2017
@heyitsanthony heyitsanthony reopened this May 2, 2017
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue May 3, 2017
clientv3: don't halt lease client if there is a lease error
d59f6c1 
Fixes etcd-io#7488
@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 7, 2020
@stale stale bot closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heyitsanthony heyitsanthony

Labels
area/clientv3 stale
Milestone
etcd-v4.0
Development

No branches or pull requests
2 participants
@gyuho @heyitsanthony