Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics in V3 #8167

Closed
davissp14 opened this issue Jun 23, 2017 · 4 comments
Closed

Metrics in V3 #8167

davissp14 opened this issue Jun 23, 2017 · 4 comments
Labels
type/bug

Comments

@davissp14
Copy link
Contributor

I noticed that when we disable v2 by using --enable-v2=false, we lose access to the /metrics endpoint.

Are there plans for exposing this to the v3 api?
@xiang90
Copy link
Contributor

xiang90 commented Jun 23, 2017

this is a bug. will be fixed.

@davissp14
Copy link
Contributor Author

davissp14 commented Jun 23, 2017 •
edited
Loading

Also, it appears that specifying --enable-v2 false doesn't work while --enable-v2=false does.

Etcd v3.2.0
screen shot 2017-06-23 at 1 01 25 pm

@heyitsanthony
Copy link
Contributor

All bool flags work like that-- the command line parser sees --enable-v2, parses it as --enable-v2=true, then expects another flag but sees false and bails.

@davissp14
Copy link
Contributor Author

Interesting, thanks for the clarifying that!

heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Jul 8, 2017
*: move v2http handlers not needing v2 store to etcdhttp
5bbbe8c 
Lets --enable-v2=false configurations provide /metrics, /health, etc.

Fixes etcd-io#8167
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Jul 8, 2017
*: move v2http handlers without /v2 prefix to etcdhttp
e29db92 
Lets --enable-v2=false configurations provide /metrics, /health, etc.

Fixes etcd-io#8167
@heyitsanthony heyitsanthony mentioned this issue Jul 8, 2017
Merged
gyuho pushed a commit that referenced this issue Jul 24, 2017
@gyuho
*: move v2http handlers without /v2 prefix to etcdhttp
493f013 
Lets --enable-v2=false configurations provide /metrics, /health, etc.

Fixes #8167
gyuho pushed a commit that referenced this issue Jul 24, 2017
@gyuho
*: move v2http handlers without /v2 prefix to etcdhttp
8ab42fb 
Lets --enable-v2=false configurations provide /metrics, /health, etc.

Fixes #8167
yudai pushed a commit to yudai/etcd that referenced this issue Oct 5, 2017
*: move v2http handlers without /v2 prefix to etcdhttp
fbbcf9a 
Lets --enable-v2=false configurations provide /metrics, /health, etc.

Fixes etcd-io#8167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davissp14 @xiang90 @heyitsanthony