Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: improve heartbeat send failures logging #10663

Merged
merged 1 commit into from
Apr 22, 2019
Merged

etcdserver: improve heartbeat send failures logging #10663

merged 1 commit into from
Apr 22, 2019

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Apr 19, 2019

hexfusion
hexfusion approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm this is very useful thanks @gyuho

@hexfusion
Copy link
Contributor

I would love to backport this, thoughts?

@jingyih
Copy link
Contributor

jingyih commented Apr 19, 2019

lgtm

@xiang90 xiang90 merged commit 216808e into etcd-io:master Apr 22, 2019
@gyuho gyuho deleted the log branch April 22, 2019 05:44
@gyuho
Copy link
Contributor Author

gyuho commented Apr 22, 2019

@hexfusion Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexfusion hexfusion hexfusion approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gyuho @hexfusion @jingyih @xiang90