Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add workaround for go-resty import to go.mod and fix import paths #10773

Closed
wants to merge 1 commit into from

Conversation

tbg
Copy link
Contributor

@tbg tbg commented May 30, 2019

go-resty is imported under its old import path by grpc-gateway.
This works around that problem until we pick up a version of
grpc-gateway that has the imports fixed.

See: go-resty/resty#230

Also fix the import paths so that updatedep.sh works again.

@tbg
Copy link
Contributor Author

tbg commented May 30, 2019

I added two commits that show the result of updatedep.sh, and another commit that shows that things "work" when we just delete the self-vendored copies from vendor. I don't intend to merge this, we need to figure out why the self-vendoring happens. I tried but no dice yet.

@tbg
Copy link
Contributor Author

tbg commented May 30, 2019

$ go mod why -m github.com/coreos/etcd
# github.com/coreos/etcd
go.etcd.io/etcd/v3
go.etcd.io/etcd/etcdmain
github.com/coreos/etcd/clientv3

Doesn't come back via go list:

go list ./... | grep coreos

Also wasn't able to find anything that imported this by grepping through the sourcecode.

@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #10773 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10773      +/-   ##
==========================================
+ Coverage   62.51%   62.67%   +0.15%     
==========================================
  Files         392      392              
  Lines       37157    37157              
==========================================
+ Hits        23230    23289      +59     
+ Misses      12330    12296      -34     
+ Partials     1597     1572      -25
Impacted Files Coverage Δ
etcdserver/api/v2http/client_auth.go 53.24% <ø> (ø) ⬆️
clientv3/lease.go 91.11% <ø> (-0.75%) ⬇️
etcdctl/ctlv3/command/watch_command.go 44.26% <ø> (ø) ⬆️
etcdserver/api/rafthttp/peer.go 78.77% <ø> (+1.11%) ⬆️
etcdserver/api/v2http/http.go 66.66% <ø> (ø) ⬆️
etcdserver/api/v3rpc/util.go 51.61% <ø> (ø) ⬆️
etcdctl/ctlv2/command/set_dir_command.go 0% <ø> (ø) ⬆️
etcdserver/api/v2v3/server.go 0% <ø> (ø) ⬆️
etcdserver/api/membership/errors.go 100% <ø> (ø) ⬆️
etcdctl/ctlv3/command/member_command.go 32.43% <ø> (ø) ⬆️
... and 221 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7121b...0ffee56. Read the comment docs.

@jingyih
Copy link
Contributor

jingyih commented May 31, 2019

I think I have seen similar issue after running the updatedep script. Could not figure out why. Thanks for digging into this.

@tbg
Copy link
Contributor Author

tbg commented May 31, 2019

PTAL, I think I got it (second commit)

@tbg tbg changed the title Add workaround for go-resty import to go.mod Add workaround for go-resty import to go.mod and fix import paths May 31, 2019
@tbg tbg changed the title Add workaround for go-resty import to go.mod and fix import paths *: Add workaround for go-resty import to go.mod and fix import paths May 31, 2019
@tbg tbg changed the title *: Add workaround for go-resty import to go.mod and fix import paths *: add workaround for go-resty import to go.mod and fix import paths May 31, 2019
@jingyih
Copy link
Contributor

jingyih commented May 31, 2019

The versioned imports were reverted due to various issues. #10766
cc @gyuho

@jingyih
Copy link
Contributor

jingyih commented May 31, 2019

I think I have seen similar issue after running the updatedep script. Could not figure out why. Thanks for digging into this.

When I tried this, we still have "v3" in all the import paths. So it might be a different issue.

@gyuho
Copy link
Contributor

gyuho commented Jun 3, 2019

Can we try again removing v3 at the top of the line https://github.com/etcd-io/etcd/blob/master/go.mod? I forgot to delete that part. Sorry for delay.

@gyuho
Copy link
Contributor

gyuho commented Jun 3, 2019

Please try #10781.

go-resty is imported under its old import path by grpc-gateway.
This works around that problem until we pick up a version of
grpc-gateway that has the imports fixed.

See: go-resty/resty#230
@tbg
Copy link
Contributor Author

tbg commented Jun 3, 2019

Yep, works! Closing this PR since it's no longer needed. Thanks @gyuho.

@tbg tbg closed this Jun 3, 2019
@gyuho
Copy link
Contributor

gyuho commented Jun 3, 2019

@tbg Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants